fix: resolve clippy warnings and rustfmt issues for CI compliance

Fix all clippy lints (collapsible if, clone on Copy, needless borrow,
redundant bindings, unused params) and apply rustfmt across the codebase.
Update test mocks to match Uuid-based trait signatures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/infrastructure/services/jwt_service.rs

@@ -262,10 +262,11 @@ impl TokenServicePort for JwtTokenService {
 mod tests {
     use super::*;
     use crate::domain::entities::user::{User, UserRole};
+    use uuid::Uuid;
 
     fn create_test_user() -> User {
         User::from_data(
-            "test-user-id".to_string(),
+            Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(),
             "testuser".to_string(),
             "test@example.com".to_string(),
             "hashed_password".to_string(),
@@ -295,7 +296,7 @@ mod tests {
         let claims = service
             .validate_token(&token)
             .expect("Should validate token");
-        assert_eq!(claims.sub, user.id());
+        assert_eq!(claims.sub, user.id().to_string());
         assert_eq!(claims.username, user.username());
         assert_eq!(claims.email, user.email());
     }

src/infrastructure/services/thumbnail_service.rs

@@ -1,6 +1,6 @@
 use bytes::Bytes;
-use image::imageops::FilterType;
 use image::codecs::jpeg::JpegEncoder;
+use image::imageops::FilterType;
 /**
  * Thumbnail Generation Service
  *
@@ -236,20 +236,16 @@ impl ThumbnailService {
     /// Unlike `get_thumbnail`, this does **not** generate a new thumbnail.
     /// Useful for non-image file types (videos) where a client-generated
     /// thumbnail may have been uploaded previously.
-    pub async fn get_cached_thumbnail(
-        &self,
-        file_id: &str,
-        size: ThumbnailSize,
-    ) -> Option<Bytes> {
+    pub async fn get_cached_thumbnail(&self, file_id: &str, size: ThumbnailSize) -> Option<Bytes> {
         // 1. Check in-memory cache
         let cache_key = ThumbnailCacheKey {
             file_id: file_id.to_string(),
             size,
         };
-        if let Some(bytes) = self.cache.get(&cache_key).await {
-            if !bytes.is_empty() {
-                return Some(bytes);
-            }
+        if let Some(bytes) = self.cache.get(&cache_key).await
+            && !bytes.is_empty()
+        {
+            return Some(bytes);
         }
 
         // 2. Check disk
@@ -285,17 +281,17 @@ impl ThumbnailService {
         let jpeg_bytes = tokio::task::spawn_blocking(move || -> Result<Vec<u8>, ThumbnailError> {
             // ── Fast path: already a correctly-sized JPEG ─────────────
             // JPEG files start with SOI marker 0xFF 0xD8.
-            if data.len() >= 2 && data[0] == 0xFF && data[1] == 0xD8 {
-                if let Ok(reader) = image::ImageReader::new(std::io::Cursor::new(&data))
-                    .with_guessed_format()
-                {
-                    if let Ok((w, h)) = reader.into_dimensions() {
-                        if w <= max_dim && h <= max_dim {
-                            // Already JPEG at correct size — zero-copy store
-                            return Ok(data.to_vec());
-                        }
-                    }
-                }
+            if data.len() >= 2
+                && data[0] == 0xFF
+                && data[1] == 0xD8
+                && let Ok(reader) =
+                    image::ImageReader::new(std::io::Cursor::new(&data)).with_guessed_format()
+                && let Ok((w, h)) = reader.into_dimensions()
+                && w <= max_dim
+                && h <= max_dim
+            {
+                // Already JPEG at correct size — zero-copy store
+                return Ok(data.to_vec());
             }
 
             // ── Slow path: decode, resize, re-encode to JPEG ─────────
@@ -637,11 +633,7 @@ impl ThumbnailPort for ThumbnailService {
             .map_err(|e| DomainError::new(ErrorKind::InternalError, "Thumbnail", e.to_string()))
     }
 
-    async fn get_cached_thumbnail(
-        &self,
-        file_id: &str,
-        size: PortThumbnailSize,
-    ) -> Option<Bytes> {
+    async fn get_cached_thumbnail(&self, file_id: &str, size: PortThumbnailSize) -> Option<Bytes> {
         self.get_cached_thumbnail(file_id, size.into()).await
     }