perf: round 11 — StoragePath joined-only, classifier fusion, memoized bodies, query-shape pack, SPA fine-grained stars
Backend (each change benchmark-gated with BEFORE replicas + equivalence gates; see examples/bench_round11_micro.rs, bench_round11_queries.rs, bench_log_writer.rs and benches/ROUND11.md — final numbers land in the follow-up doc commit): - StoragePath re-representation: single canonical joined String, segments derived on demand; File/Folder drop the duplicated path_string field (4000→1000 allocs per 500-row listing page) - Display classifier fusion: classify_display shares one stack-lowered extension across the three decision trees; call sites in FileDto, folder/favorites/recent handlers, trash, path-resolver (+ interning where Arc::from was still used) - /status.php and /openapi.json memoized into OnceLock<Bytes> (openapi rebuilt a 171 KiB spec per request: 2.8 ms → 18 ns) - NC upload-session PROPFIND: write! + pre-sized body + stack RFC2822 dates (2.3-2.6x, 2582→772 allocs at 256 chunks) - REST download: dead FileDto clone removed (capture mime/size + move) - CalendarEventDto/TrashedItem into_parts moves (11 KiB ical_data memcpy gone per CalDAV row); CardDAV getlastmodified stack render - 4xx path: borrowed ErrorResponse serialize, ErrorKind::as_str, not_found/already_exists clone kill - vCard emit via write!; search page moved out with into_iter skip/take; content-hit UUIDs parsed once; group last-user check via HashSet - RateLimiter: lock-free get + insert (and_upsert_with variant REJECTED by benchmark); CSRF token borrow-compare + borrowed cookie extraction - Thumbnail/preview ETags built from as_str (Debug-identical bytes) - Encrypted backend: encrypt_in_place_detached single-buffer write path, chunk-sized reserve in collect_stream; retry labels made lazy - PG: deferred upload registration 3→1 round-trips (persist_file CTE template); direct_grant_cache for Calendar/AddressBook/Playlist authz (single-flight + set_role/clear_role invalidation); expand_user tokio::join!; geo clusters min(uuid)::text; recluster face assignment batched into one UNNEST update - People recluster cosine: norms precomputed once (bit-identical gate) - NC capabilities poll logs demoted to debug; tracing-appender dep added for the log-writer benchmark Frontend: - ResourceList.selectedEntries O(N)-per-toggle → id-index projection O(k log k); favorites/recent consume the batchToolbar snippet param and drop their duplicate filter + dead selectedIds mirror - Recent: star state via new favoriteIds prop — a star click no longer rebuilds all N entries - admin timeAgo >30d fallback uses the cached Intl.DateTimeFormat - vitest gates in src/lib/components/round11.bench.test.ts Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ABhTEHuGujvwoodh67Kga7
This commit is contained in:
@@ -188,6 +188,50 @@ fn ext_of(name: &str) -> Option<&str> {
|
||||
Some(after_dot)
|
||||
}
|
||||
|
||||
/// Longest extension any classifier table matches ("appimage", "markdown"
|
||||
/// — 8 bytes). Longer extensions can only ever hit the `_` arms, so they
|
||||
/// skip the buffer entirely.
|
||||
const MAX_CLASSIFIED_EXT: usize = 16;
|
||||
|
||||
/// Lowercase `ext` into `buf` without heap allocation. Returns `None` for
|
||||
/// extensions longer than any table entry — the caller must then take the
|
||||
/// same default arm `ext.to_ascii_lowercase()` would have fallen into.
|
||||
fn lower_ext_into<'b>(ext: &str, buf: &'b mut [u8; MAX_CLASSIFIED_EXT]) -> Option<&'b str> {
|
||||
let bytes = ext.as_bytes();
|
||||
if bytes.len() > MAX_CLASSIFIED_EXT {
|
||||
return None;
|
||||
}
|
||||
for (i, b) in bytes.iter().enumerate() {
|
||||
buf[i] = b.to_ascii_lowercase();
|
||||
}
|
||||
// ASCII-lowercasing bytes keeps UTF-8 validity (non-ASCII bytes pass
|
||||
// through untouched).
|
||||
std::str::from_utf8(&buf[..bytes.len()]).ok()
|
||||
}
|
||||
|
||||
/// The three display classifications for one `(name, mime)` pair.
|
||||
pub struct DisplayClass {
|
||||
pub icon_class: &'static str,
|
||||
pub icon_special_class: &'static str,
|
||||
pub category: &'static str,
|
||||
}
|
||||
|
||||
/// Run all three classifiers over one `(name, mime)` pair, lowering the
|
||||
/// extension **once into a stack buffer** instead of each classifier
|
||||
/// allocating its own `to_ascii_lowercase()` String on the fallback path
|
||||
/// (generic/empty MIME rows — common for code and unknown types). Each
|
||||
/// decision tree is byte-for-byte the classifier it replaces
|
||||
/// (benches/ROUND11.md §21 gates the equivalence over a corpus).
|
||||
pub fn classify_display(name: &str, mime: &str) -> DisplayClass {
|
||||
let mut buf = [0u8; MAX_CLASSIFIED_EXT];
|
||||
let ext = ext_of(name).and_then(|e| lower_ext_into(e, &mut buf));
|
||||
DisplayClass {
|
||||
icon_class: icon_class_with_ext(mime, ext),
|
||||
icon_special_class: icon_special_class_with_ext(mime, ext),
|
||||
category: category_with_ext(mime, ext),
|
||||
}
|
||||
}
|
||||
|
||||
// ─── Icon class (FontAwesome) ────────────────────────────────────────
|
||||
|
||||
/// Returns the FontAwesome icon class for a file, considering both MIME
|
||||
@@ -196,6 +240,12 @@ fn ext_of(name: &str) -> Option<&str> {
|
||||
/// Use this instead of the old `mime_to_icon_class` whenever the filename
|
||||
/// is available.
|
||||
pub fn icon_class_for(name: &str, mime: &str) -> &'static str {
|
||||
let mut buf = [0u8; MAX_CLASSIFIED_EXT];
|
||||
let ext = ext_of(name).and_then(|e| lower_ext_into(e, &mut buf));
|
||||
icon_class_with_ext(mime, ext)
|
||||
}
|
||||
|
||||
fn icon_class_with_ext(mime: &str, ext: Option<&str>) -> &'static str {
|
||||
// 1. Try specific MIME matches first
|
||||
match mime {
|
||||
"application/pdf" => return "fas fa-file-pdf",
|
||||
@@ -273,8 +323,8 @@ pub fn icon_class_for(name: &str, mime: &str) -> &'static str {
|
||||
}
|
||||
|
||||
// 3. Extension-based fallback (for application/octet-stream, empty, etc.)
|
||||
if let Some(ext) = ext_of(name) {
|
||||
return match ext.to_ascii_lowercase().as_str() {
|
||||
if let Some(ext) = ext {
|
||||
return match ext {
|
||||
"pdf" => "fas fa-file-pdf",
|
||||
"doc" | "docx" | "odt" | "rtf" => "fas fa-file-word",
|
||||
"xls" | "xlsx" | "ods" | "csv" => "fas fa-file-excel",
|
||||
@@ -311,6 +361,12 @@ pub fn icon_class_for(name: &str, mime: &str) -> &'static str {
|
||||
/// The returned class maps to CSS rules in `style.css` that set colours,
|
||||
/// backgrounds and decorative pseudo-elements per file type.
|
||||
pub fn icon_special_class_for(name: &str, mime: &str) -> &'static str {
|
||||
let mut buf = [0u8; MAX_CLASSIFIED_EXT];
|
||||
let ext = ext_of(name).and_then(|e| lower_ext_into(e, &mut buf));
|
||||
icon_special_class_with_ext(mime, ext)
|
||||
}
|
||||
|
||||
fn icon_special_class_with_ext(mime: &str, ext: Option<&str>) -> &'static str {
|
||||
// 1. Specific MIME matches
|
||||
match mime {
|
||||
"application/pdf" => return "pdf-icon",
|
||||
@@ -390,8 +446,8 @@ pub fn icon_special_class_for(name: &str, mime: &str) -> &'static str {
|
||||
}
|
||||
|
||||
// 3. Extension-based fallback
|
||||
if let Some(ext) = ext_of(name) {
|
||||
return match ext.to_ascii_lowercase().as_str() {
|
||||
if let Some(ext) = ext {
|
||||
return match ext {
|
||||
"pdf" => "pdf-icon",
|
||||
"doc" | "docx" | "odt" | "rtf" => "doc-icon",
|
||||
"xls" | "xlsx" | "ods" | "csv" => "spreadsheet-icon",
|
||||
@@ -437,6 +493,12 @@ pub fn icon_special_class_for(name: &str, mime: &str) -> &'static str {
|
||||
|
||||
/// Returns a human-readable category label, considering MIME + extension.
|
||||
pub fn category_for(name: &str, mime: &str) -> &'static str {
|
||||
let mut buf = [0u8; MAX_CLASSIFIED_EXT];
|
||||
let ext = ext_of(name).and_then(|e| lower_ext_into(e, &mut buf));
|
||||
category_with_ext(mime, ext)
|
||||
}
|
||||
|
||||
fn category_with_ext(mime: &str, ext: Option<&str>) -> &'static str {
|
||||
// 1. Specific MIME matches
|
||||
match mime {
|
||||
"application/pdf" => return "PDF",
|
||||
@@ -489,8 +551,8 @@ pub fn category_for(name: &str, mime: &str) -> &'static str {
|
||||
}
|
||||
|
||||
// 3. Extension fallback
|
||||
if let Some(ext) = ext_of(name) {
|
||||
return match ext.to_ascii_lowercase().as_str() {
|
||||
if let Some(ext) = ext {
|
||||
return match ext {
|
||||
"pdf" => "PDF",
|
||||
"doc" | "docx" | "odt" | "rtf" | "txt" => "Document",
|
||||
"xls" | "xlsx" | "ods" | "csv" => "Spreadsheet",
|
||||
|
||||
Reference in New Issue
Block a user