cjw/Oxicloud
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(api): define COMPOSE_FILE so the leftover diagnosis actually runs

Browse Source 
52c31a68 added a per-leftover refcount dump to storage_cleanup_check.sh
but referenced COMPOSE_FILE, which that script never defines — only
thumb_import_check.sh does. It would have run `docker compose -f ""`,
failed, and been swallowed by the `|| true` guarding the loop.

A silent no-op: the diagnosis would print nothing and the failure would
look exactly as uninformative as the one it was written to explain. The
same shape as the three bugs this suite has already caught — an error
dressed up as an unremarkable result — and I wrote it into the tool
meant to find them.

The `|| true` stays, so one unreadable blob cannot abort the loop before
the others report.
This commit is contained in:
Edouard Vanbelle
2026-08-28 07:43:41 +02:00
parent fced39c798
commit 2b9505f344
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api/storage_cleanup_check.sh
+4
View File
@@ -18,6 +18,10 @@ set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)" REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
STORAGE_PATH="${OXICLOUD_STORAGE_PATH:-$REPO_ROOT/tests/api/storage}" STORAGE_PATH="${OXICLOUD_STORAGE_PATH:-$REPO_ROOT/tests/api/storage}"
# Needed by the leftover diagnosis below. Without it `docker compose -f ""`
# fails and the `|| true` there swallows it, so the diagnosis silently prints
# nothing and the failure looks exactly as uninformative as before.
COMPOSE_FILE="$REPO_ROOT/tests/common/docker-compose.test.yml"
# shellcheck source=test.env # shellcheck source=test.env
source "$SCRIPT_DIR/test.env" source "$SCRIPT_DIR/test.env"