style(server): correct clippy warnings

2026-05-04 12:46:57 +02:00
parent 97ea87efc2
commit 6e1c435098
4 changed files with 13 additions and 20 deletions
@@ -752,10 +752,8 @@ impl WebDavAdapter {
                        _ => (),
                    }
                }
-                Ok(Event::Text(e)) => {
-                    if current_prop.is_some() {
-                        current_text.push_str(&e.decode().unwrap_or_default());
-                    }
+                Ok(Event::Text(e)) if current_prop.is_some() => {
+                    current_text.push_str(&e.decode().unwrap_or_default());
                }
                Ok(Event::End(ref e)) => {
                    let name = e.name();
@@ -961,10 +959,8 @@ impl WebDavAdapter {
                        _ => (),
                    }
                }
-                Ok(Event::Text(e)) => {
-                    if in_owner {
-                        owner_text.push_str(&e.decode().unwrap_or_default());
-                    }
+                Ok(Event::Text(e)) if in_owner => {
+                    owner_text.push_str(&e.decode().unwrap_or_default());
                }
                Ok(Event::End(ref e)) => {
                    let name = e.name();
@@ -253,7 +253,7 @@ impl SearchService {
        }

        // Merge files + folders by relevance and truncate to the final limit
-        suggestions.sort_by(|a, b| b.relevance_score.cmp(&a.relevance_score));
+        suggestions.sort_by_key(|f| Reverse(f.relevance_score));
        suggestions.truncate(limit);

        let elapsed = start.elapsed().as_millis() as u64;
@@ -346,13 +346,13 @@ impl SearchUseCase for SearchService {
                    enriched_folders.sort_by_cached_key(|f| Reverse(f.name.to_lowercase()));
                }
                "date" => {
-                    enriched_folders.sort_by(|a, b| a.modified_at.cmp(&b.modified_at));
+                    enriched_folders.sort_by_key(|f| f.modified_at);
                }
                "date_desc" => {
-                    enriched_folders.sort_by(|a, b| b.modified_at.cmp(&a.modified_at));
+                    enriched_folders.sort_by_key(|f| Reverse(f.modified_at));
                }
                _ => {
-                    enriched_folders.sort_by(|a, b| b.relevance_score.cmp(&a.relevance_score));
+                    enriched_folders.sort_by_key(|f| Reverse(f.relevance_score));
                }
            }

@@ -432,13 +432,13 @@ impl SearchUseCase for SearchService {
                enriched_folders.sort_by_cached_key(|f| Reverse(f.name.to_lowercase()));
            }
            "date" => {
-                enriched_folders.sort_by(|a, b| a.modified_at.cmp(&b.modified_at));
+                enriched_folders.sort_by_key(|f| f.modified_at);
            }
            "date_desc" => {
-                enriched_folders.sort_by(|a, b| b.modified_at.cmp(&a.modified_at));
+                enriched_folders.sort_by_key(|f| Reverse(f.modified_at));
            }
            _ => {
-                enriched_folders.sort_by(|a, b| b.relevance_score.cmp(&a.relevance_score));
+                enriched_folders.sort_by_key(|f| Reverse(f.relevance_score));
            }
        }

@@ -150,7 +150,6 @@ fn strip_username_prefix(path: &str) -> &str {
    }
 }

-
 // ─── Helper: extract user from request ───────────────────────────────

 fn extract_user(req: &Request<Body>) -> Result<AuthUser, AppError> {
@@ -495,10 +495,8 @@ fn parse_proppatch_favorite(body: &str) -> Option<u8> {
                let text = e.decode().ok()?;
                return text.trim().parse::<u8>().ok();
            }
-            Ok(Event::End(ref e)) => {
-                if e.local_name().as_ref() == b"favorite" {
-                    inside_favorite = false;
-                }
+            Ok(Event::End(ref e)) if e.local_name().as_ref() == b"favorite" => {
+                inside_favorite = false;
            }
            Ok(Event::Eof) => break,
            Err(_) => break,