cjw/Oxicloud
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat(ui:files): ensure conext menu is build on click + stick action bar & breadcrumb

Browse Source 
ensure conext menu is build on click: API call to determine if user has access to item's parent folder is done only if user request context menu
    (lazy API call)
This commit is contained in:
Edouard Vanbelle
2026-07-20 19:01:56 +02:00
parent 4f3309e087
commit c6b856bfc7
4 changed files with 74 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/routes/favorites/+page.svelte
+9 -11
View File
@@ -28,7 +28,7 @@
type ItemContext
} from '$lib/components/ResourceList.svelte';
import { confirmDialog, promptDialog } from '$lib/stores/dialogs.svelte';
import { folderAccessCached, warmFolderAccess } from '$lib/utils/folderAccess';
import { folderAccessCached, probeFolderAccess } from '$lib/utils/folderAccess';
import { t } from '$lib/i18n/index.svelte';
let raw = $state<FavoritesResourceItem[]>([]);
@@ -124,16 +124,6 @@
]);
cursor = page.next_cursor;
void owners.resolve(page.items.map((i) => i.resource.created_by));
// Pre-warm the folder-access cache for each row's parent
// folder — the "Open parent folder" context-menu entry
// gates on the cached boolean. Fire-and-forget: probes for
// already-cached ids no-op.
warmFolderAccess(
page.items.map((i) => {
const r = i.resource as FileItem | FolderItem;
return isFile(r) ? r.folder_id : r.parent_id;
})
);
} catch (e) {
console.error('favorites: load error', e);
error = t('errors_loadFailed', 'Failed to load items');
@@ -345,6 +335,14 @@
showPath
selectable
{contextActions}
menuPrepare={async (item) => {
// Lazy folder-access probe — fires only when the user actually
// opens the context menu on a row, not proactively for every
// row on load. Cached in the LRU (see `folderAccess.ts`) so
// subsequent right-clicks on the same folder are instant.
const pid = parentFolderId(item);
if (pid) await probeFolderAccess(pid);
}}
{groupBys}
bind:groupBy
bind:reversed
frontend/src/routes/recent/+page.svelte
+9 -11
View File
@@ -35,7 +35,7 @@
// filter is inside ResourceList (gated on `showDotfileToggle`).
import { preferences } from '$lib/stores/preferences.svelte';
import { isDotfile } from '$lib/utils/dotfileFilter';
import { folderAccessCached, warmFolderAccess } from '$lib/utils/folderAccess';
import { folderAccessCached, probeFolderAccess } from '$lib/utils/folderAccess';
import { t } from '$lib/i18n/index.svelte';
import Icon from '$lib/icons/Icon.svelte';
@@ -120,16 +120,6 @@
]);
cursor = page.next_cursor;
void owners.resolve(page.items.map((i) => i.resource.updated_by));
// Pre-warm the folder-access cache for each row's parent
// folder so the "Open parent folder" context-menu entry has
// a resolved boolean by the time the user right-clicks. Fire-
// and-forget: probes for already-cached ids no-op.
warmFolderAccess(
page.items.map((i) => {
const r = i.resource as FileItem | FolderItem;
return isFile(r) ? r.folder_id : r.parent_id;
})
);
} catch (e) {
console.error('recent: load error', e);
error = t('errors_loadFailed', 'Failed to load items');
@@ -387,6 +377,14 @@
showDotfileToggle
selectable
{contextActions}
menuPrepare={async (item) => {
// Lazy folder-access probe — fires only when the user actually
// opens the context menu on a row, not proactively for every
// row on load. Cached in the LRU forever after (per-session);
// subsequent right-clicks on the same folder are instant.
const pid = parentFolderId(item);
if (pid) await probeFolderAccess(pid);
}}
{groupBys}
bind:groupBy
bind:reversed