2 Commits

Author	SHA1	Message	Date
Edouard Vanbelle	5cb01b201d	fix(nc/webdav): honour Overwrite on MOVE; restore-onto-existing → 412 ... Closes G4 / G5 / K5. handle_move now resolves the destination once before the file/folder dispatch and applies RFC 4918 §9.9.4: - Overwrite: F on a collision → 412 Precondition Failed, source untouched, destination untouched. - Overwrite: T (or absent) on a collision → delete the existing destination, then proceed → 204 No Content. - No collision → 201 Created (unchanged). The same destination lookup powers the 201-vs-204 status decision, so adding the precondition guard adds zero extra DB hits on the happy path. handle_restore now catches the unique-index collision out of restore_item and returns 412 instead of letting it bubble as 500. Mirrors the G4 semantics for the trashbin surface (restore has no Overwrite header so the refusal is unconditional; client resolves by renaming the live file first). Sabre/DAV's CorePlugin and our test pins agreed independently — NC clients expect this exact behavior, and the new G5b/G5c positive-case tests guard against a regression that hard-rejected every MOVE.	2026-06-17 01:49:13 +02:00
Edouard Vanbelle	595273277b	test(e2e): webdav + nextcloud full e2e test coverage ... add a full coverage of Webdav and Nextcloud purpose: prepare move to Drives and ensure no regression at all test scenarios are in docs/plan/BASELINE_TESTS_NC_WEBDAV.md current existing bugs identified via these tests: ┌──────────┬─────────┬────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Bug │ Surface │ Pin location │ ├──────────┼─────────┼────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ G4/G5/K5 │ NC │ AlreadyExists → 500 instead of 412 (handle_move + trashbin restore) │ ├──────────┼─────────┼────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ G9 │ NC │ Folder DELETE not row-recursive — orphan descendants stay live │ ├──────────┼─────────┼────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ M5/M7 │ Native │ resolve_path_for_user mismatch — PUT writes, GET reads via lenient lookup, MOVE/DELETE can't find │ │ │ │ via strict │ ├──────────┼─────────┼────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ M8 │ Native │ COPY discards destination filename — collides with source │ ├──────────┼─────────┼────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ N2 │ Native │ LOCK creates the token, mutators don't check it — class-2 advertisement is aspirational │ └──────────┴─────────┴────────────────────────────────────────────────────────────────────────────────────────────────────┘	2026-06-13 19:01:40 +02:00