Files
Oxicloud/frontend/src/lib/components/listDerives.bench.test.ts
T
Claude fdf445d2b0 perf: round 9 — decorator PUT reactivation, session/search/dedup alloc purges, PROPFIND join!, folder-level cascade
Benchmark-gated round (benches/ROUND9.md): every change carries a
BEFORE/AFTER bench with equivalence/safety gates; verdicts below are from
the committed harnesses on 4 cores / local PG 16.

Backend:
- Blob decorators (Retry/Cached) now forward put_blob_from_bytes_unsynced
  + sync_blobs — the trait default had silently reinstated HEAD-before-PUT
  per chunk on decorated remote stacks, undoing ROUND3 §8. Full production
  stack: 500 probes -> 0, 1.9x wall at 10 ms RTT (bench_s3_put §3).
- NC PROPFIND per-page enrichment triple (favorites / oc:fileid / dead
  props) overlapped with tokio::join!: 2.07x local, 2.86x at 5 ms RTT
  (bench_nc_enrich_join, injected-latency decide-by-bench).
- Search enrichment consumes its DTOs and carries the interned Arc<str>
  display fields end-to-end (SearchFileResultDto type change, OpenAPI
  shape preserved): enrich_file 2.0x, 11.6 -> 2.2 allocs/row; the NC
  REPORT conversion stops re-running all three classifiers per row
  (bench_search_enrich).
- NC session Arc end-to-end: SharedNcSession extractor (8 -> 0 allocs),
  Arc<FolderDto> chroot cache (4 -> 0/hit), single shared Arc<CurrentUser>
  + lazy span render (11 -> 6/build) (bench_nc_session).
- Storage micro-pack: atomic create_new chunk writes (2.1x fresh),
  stream_chunks over the manifest Arc (4097 -> 0 allocs/read incl. the
  Range path), manifest single-flight (herd 64 -> 1 loads), hex_lower for
  chunk Content-MD5 (18 -> 1 allocs) (bench_storage_micro).
- OCS capabilities memoized into OnceLock<[Bytes;2]>: 237x, 102 -> 0
  allocs/poll, byte-identical (bench_capabilities_static).
- Drive::is_empty COUNT(*) sum -> EXISTS: 34.4x on a 100k-file drive
  (bench_drive_is_empty).
- favorites/recents row-map ROUND7 port: path/name/blob_hash moved,
  -2.75 allocs/row (bench_resource_row_map §2).
- Folder rows decode binary UUIDs (ROUND6 §10 port): 1.03-1.07x page
  fetch, honest verdict incl. one noise-band wash documented
  (bench_folder_uuid_decode).
- Authz: file cascade decision decomposed into memoized folder-level
  decision + direct-grant lookup (ROUND8 deferred item). Cold shared-album
  first view 592 -> 418 µs/thumb; warm path unchanged; safety gates incl.
  new direct-grant sibling isolation, revoke-flush re-verified, full
  integration authz suite green (bench_thumbnail_cascade_cache).

Frontend (vitest gates committed beside the code):
- resolveLabel/resolveRecipient O(directory) scan -> id-keyed Map: 13.9x
  (recipients.bench.test.ts).
- ResourceList selection-prune effect skips when nothing is selected
  (100 -> 0 Set builds per drain) and the photos timeline reads a
  listener-fed mobile flag instead of matchMedia per recompute
  (listDerives.bench.test.ts).

Verification: cargo fmt + clippy --all-features --all-targets -D warnings
clean; 524 unit + 554 integration (--cfg integration_tests) tests pass;
frontend npm run check clean with 293 vitest tests green.

Deferred with rationale in ROUND9.md: CalDAV authz-before-fetch reorder
(maintainer sign-off), per-page batched parent resolution, JWT-claims
Arc<str>, batch_operations signature widening.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XDc9VtXvskJ6dnMRraSndn
2026-07-18 16:12:04 +00:00

134 lines
4.5 KiB
TypeScript

import { describe, expect, it } from 'vitest';
/**
* Benchmark gates for two per-page derive cleanups (round 9):
*
* [1] ResourceList's selection-prune `$effect` built an O(N) id `Set` on
* EVERY `items` change (every infinite-scroll page) even when nothing
* was selected — the loop it feeds never runs in that case. The shipped
* guard (`if (selected.size === 0) return`) makes the empty-selection
* page append free while keeping the pruned result byte-identical when
* a selection exists.
*
* [2] The photos timeline derive called `window.matchMedia(...)` on every
* recompute (every 60-photo page append) for a boolean that changes
* only on viewport-class crossings. The shipped code hoists it into
* state fed by a single MediaQueryList `change` listener.
*
* Both are modeled as pure replicas of the effect/derive bodies (no jsdom
* mounting needed) with instrumentation counters, mirroring the shipped
* control flow exactly.
*/
interface Item {
id: string;
}
const page = (start: number, n: number): Item[] =>
Array.from({ length: n }, (_, i) => ({ id: `it-${start + i}` }));
/** BEFORE — verbatim effect body: unconditional Set build. */
function pruneBefore(items: Item[], selected: Set<string>, counter: { setBuilds: number }) {
counter.setBuilds++;
const ids = new Set(items.map((i) => i.id));
for (const id of [...selected]) {
if (!ids.has(id)) selected.delete(id);
}
}
/** AFTER — the shipped body: skip entirely while nothing is selected. */
function pruneAfter(items: Item[], selected: Set<string>, counter: { setBuilds: number }) {
if (selected.size === 0) return;
counter.setBuilds++;
const ids = new Set(items.map((i) => i.id));
for (const id of [...selected]) {
if (!ids.has(id)) selected.delete(id);
}
}
describe('selection-prune guard (benchmark gate)', () => {
it('empty selection: zero Set builds across a 100-page drain (was 100)', () => {
const beforeCounter = { setBuilds: 0 };
const afterCounter = { setBuilds: 0 };
let items: Item[] = [];
for (let p = 0; p < 100; p++) {
items = [...items, ...page(p * 50, 50)];
pruneBefore(items, new Set(), beforeCounter);
pruneAfter(items, new Set(), afterCounter);
}
expect(beforeCounter.setBuilds).toBe(100);
expect(afterCounter.setBuilds).toBe(0);
});
it('active selection: pruned set identical to the unguarded version', () => {
const items = page(0, 200);
// Selection holds survivors + ids that vanished on reload.
const seed = ['it-3', 'it-77', 'gone-1', 'it-150', 'gone-2'];
const a = new Set(seed);
const b = new Set(seed);
pruneBefore(items, a, { setBuilds: 0 });
pruneAfter(items, b, { setBuilds: 0 });
expect([...b].sort()).toEqual([...a].sort());
expect(b.has('gone-1')).toBe(false);
expect(b.has('it-3')).toBe(true);
});
});
// ── [2] matchMedia hoist ────────────────────────────────────────────────────
interface MqlStub {
matches: boolean;
listeners: ((e: { matches: boolean }) => void)[];
}
function makeMatchMedia(counter: { calls: number }, stub: MqlStub) {
return () => {
counter.calls++;
return {
get matches() {
return stub.matches;
},
addEventListener: (_: 'change', fn: (e: { matches: boolean }) => void) => {
stub.listeners.push(fn);
},
removeEventListener: () => {}
};
};
}
describe('photos matchMedia hoist (benchmark gate)', () => {
it('P recomputes: 1 matchMedia call instead of P, identical booleans', () => {
const P = 50;
const stub: MqlStub = { matches: false, listeners: [] };
// BEFORE — the derive body queries per recompute.
const beforeCounter = { calls: 0 };
const mmBefore = makeMatchMedia(beforeCounter, stub);
const beforeValues: boolean[] = [];
for (let i = 0; i < P; i++) {
beforeValues.push(mmBefore().matches);
}
expect(beforeCounter.calls).toBe(P);
// AFTER — one query + listener; recomputes read the state boolean.
const afterCounter = { calls: 0 };
const mmAfter = makeMatchMedia(afterCounter, stub);
const mql = mmAfter();
let isMobile = mql.matches;
mql.addEventListener('change', (e) => {
isMobile = e.matches;
});
const afterValues: boolean[] = [];
for (let i = 0; i < P; i++) {
afterValues.push(isMobile);
}
expect(afterCounter.calls).toBe(1);
expect(afterValues).toEqual(beforeValues);
// A viewport-class crossing propagates through the listener.
stub.matches = true;
for (const fn of stub.listeners) fn({ matches: true });
expect(isMobile).toBe(true);
});
});