Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
55 lines
2.2 KiB
TypeScript
55 lines
2.2 KiB
TypeScript
import { test, expect } from './coverage-helpers';
|
|
import { apiLogin, seedFilesAndFolders } from '../scenarios/helpers';
|
|
|
|
/**
|
|
* Loads every primary route while authenticated. Each route is its own test
|
|
* (own page/document) so its `window.__coverage__` is captured before the next
|
|
* navigation resets it — a `goto` loop in one test would only keep the last
|
|
* route's data. Visiting a route mounts its `+page.svelte` and the API
|
|
* endpoint modules it imports, which is the bulk of first-load coverage.
|
|
*/
|
|
let seeded = false;
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await apiLogin(page);
|
|
if (!seeded) {
|
|
// Seed once per worker. Tolerant of a re-seed (e.g. after a worker reset)
|
|
// hitting "already exists" so it never fails an unrelated route test.
|
|
await seedFilesAndFolders(page).catch(() => {});
|
|
seeded = true;
|
|
}
|
|
});
|
|
|
|
// Routes that render inside the standard app shell (assert the shell logo).
|
|
const SHELL_ROUTES: { path: string; name: string }[] = [
|
|
{ path: '/files', name: 'files' },
|
|
{ path: '/shared', name: 'shared' },
|
|
{ path: '/shared-with-me', name: 'shared-with-me' },
|
|
{ path: '/recent', name: 'recent' },
|
|
{ path: '/favorites', name: 'favorites' },
|
|
{ path: '/photos', name: 'photos' },
|
|
{ path: '/music', name: 'music' },
|
|
{ path: '/trash', name: 'trash' },
|
|
{ path: '/search?q=README', name: 'search' },
|
|
{ path: '/profile', name: 'profile' },
|
|
{ path: '/groups', name: 'groups' },
|
|
{ path: '/admin', name: 'admin' },
|
|
];
|
|
|
|
for (const route of SHELL_ROUTES) {
|
|
test(`route ${route.name} mounts inside the app shell`, async ({ page }) => {
|
|
await page.goto(route.path);
|
|
await expect(page.getByTestId('appshell-logo-link')).toBeVisible({ timeout: 15_000 });
|
|
// Let lazy chunks + onMount data fetches settle so their code is exercised.
|
|
await page.waitForLoadState('networkidle').catch(() => {});
|
|
});
|
|
}
|
|
|
|
// The device-pairing route is a standalone page (OAuth device-code flow); it
|
|
// does NOT use the app shell, so assert its own form instead.
|
|
test('route device renders the pairing form', async ({ page }) => {
|
|
await page.goto('/device');
|
|
await expect(page.getByTestId('device-code-form')).toBeVisible({ timeout: 15_000 });
|
|
await expect(page.getByTestId('device-code-input')).toBeVisible();
|
|
});
|