Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
204 lines
4.1 KiB
Svelte
204 lines
4.1 KiB
Svelte
<script lang="ts">
|
||
import type { Snippet } from 'svelte';
|
||
import { t } from '$lib/i18n/index.svelte';
|
||
|
||
interface Props {
|
||
open: boolean;
|
||
title?: string;
|
||
/** Called when the user requests close (backdrop click, Escape, ✕). */
|
||
onclose?: () => void;
|
||
children?: Snippet;
|
||
footer?: Snippet;
|
||
}
|
||
|
||
let { open = $bindable(false), title, onclose, children, footer }: Props = $props();
|
||
|
||
let dialogEl = $state<HTMLElement | null>(null);
|
||
let prevFocus: HTMLElement | null = null;
|
||
|
||
function close() {
|
||
open = false;
|
||
onclose?.();
|
||
}
|
||
|
||
const FOCUSABLE =
|
||
'a[href], button:not([disabled]), textarea, input, select, [tabindex]:not([tabindex="-1"])';
|
||
|
||
function focusables(): HTMLElement[] {
|
||
if (!dialogEl) return [];
|
||
return Array.from(dialogEl.querySelectorAll<HTMLElement>(FOCUSABLE)).filter(
|
||
(el) => el.offsetParent !== null || el === document.activeElement
|
||
);
|
||
}
|
||
|
||
function onkeydown(e: KeyboardEvent) {
|
||
if (e.key === 'Escape') {
|
||
close();
|
||
return;
|
||
}
|
||
// Focus trap: keep Tab cycling inside the dialog.
|
||
if (e.key === 'Tab') {
|
||
const items = focusables();
|
||
if (items.length === 0) return;
|
||
const first = items[0];
|
||
const last = items[items.length - 1];
|
||
const active = document.activeElement as HTMLElement | null;
|
||
if (e.shiftKey && active === first) {
|
||
e.preventDefault();
|
||
last.focus();
|
||
} else if (!e.shiftKey && active === last) {
|
||
e.preventDefault();
|
||
first.focus();
|
||
}
|
||
}
|
||
}
|
||
|
||
// On open: remember the previously focused element and move focus into the
|
||
// dialog. On close: restore focus so keyboard users aren't dumped at <body>.
|
||
$effect(() => {
|
||
if (open) {
|
||
prevFocus = (document.activeElement as HTMLElement | null) ?? null;
|
||
requestAnimationFrame(() => {
|
||
const items = focusables();
|
||
(items[0] ?? dialogEl)?.focus();
|
||
});
|
||
} else if (prevFocus) {
|
||
prevFocus.focus();
|
||
prevFocus = null;
|
||
}
|
||
});
|
||
</script>
|
||
|
||
<svelte:window onkeydown={open ? onkeydown : undefined} />
|
||
|
||
{#if open}
|
||
<!-- backdrop -->
|
||
<div
|
||
class="modal__backdrop"
|
||
role="presentation"
|
||
onclick={(e) => {
|
||
if (e.target === e.currentTarget) close();
|
||
}}
|
||
>
|
||
<div
|
||
class="modal"
|
||
role="dialog"
|
||
aria-modal="true"
|
||
aria-label={title}
|
||
tabindex="-1"
|
||
data-testid="modal"
|
||
bind:this={dialogEl}
|
||
>
|
||
{#if title}
|
||
<header class="modal__header">
|
||
<h2 class="modal__title">{title}</h2>
|
||
<button
|
||
class="modal__close"
|
||
aria-label={t('common.close', 'Close')}
|
||
data-testid="modal-close-btn"
|
||
onclick={close}>×</button
|
||
>
|
||
</header>
|
||
{/if}
|
||
<div class="modal__body">
|
||
{@render children?.()}
|
||
</div>
|
||
{#if footer}
|
||
<footer class="modal__footer">
|
||
{@render footer()}
|
||
</footer>
|
||
{/if}
|
||
</div>
|
||
</div>
|
||
{/if}
|
||
|
||
<style>
|
||
.modal__backdrop {
|
||
position: fixed;
|
||
inset: 0;
|
||
background: var(--color-overlay);
|
||
display: flex;
|
||
align-items: center;
|
||
justify-content: center;
|
||
z-index: 900;
|
||
padding: 1rem;
|
||
animation: modal-fade 0.16s ease;
|
||
}
|
||
|
||
.modal {
|
||
background: var(--color-bg-surface);
|
||
color: var(--color-text);
|
||
border-radius: var(--radius-lg);
|
||
box-shadow: var(--shadow-xl);
|
||
width: min(92vw, 32rem);
|
||
max-height: 90vh;
|
||
overflow: auto;
|
||
display: flex;
|
||
flex-direction: column;
|
||
animation: modal-pop 0.18s ease;
|
||
}
|
||
|
||
.modal__header {
|
||
display: flex;
|
||
align-items: center;
|
||
justify-content: space-between;
|
||
padding: 1rem 1.25rem;
|
||
border-bottom: 1px solid var(--color-border);
|
||
}
|
||
|
||
.modal__title {
|
||
margin: 0;
|
||
font-size: 1.125rem;
|
||
}
|
||
|
||
.modal__close {
|
||
background: none;
|
||
border: none;
|
||
font-size: 1.5rem;
|
||
line-height: 1;
|
||
cursor: pointer;
|
||
color: var(--color-text-muted);
|
||
}
|
||
|
||
.modal__body {
|
||
padding: 1.25rem;
|
||
}
|
||
|
||
.modal__footer {
|
||
display: flex;
|
||
justify-content: flex-end;
|
||
gap: 0.5rem;
|
||
padding: 1rem 1.25rem;
|
||
border-top: 1px solid var(--color-border);
|
||
}
|
||
|
||
@keyframes modal-fade {
|
||
from {
|
||
opacity: 0;
|
||
}
|
||
|
||
to {
|
||
opacity: 1;
|
||
}
|
||
}
|
||
|
||
@keyframes modal-pop {
|
||
from {
|
||
opacity: 0;
|
||
transform: translateY(8px) scale(0.98);
|
||
}
|
||
|
||
to {
|
||
opacity: 1;
|
||
transform: translateY(0) scale(1);
|
||
}
|
||
}
|
||
|
||
@media (prefers-reduced-motion: reduce) {
|
||
.modal__backdrop,
|
||
.modal {
|
||
animation: none;
|
||
}
|
||
}
|
||
</style>
|