Dionisio
4197cc3b7b
1. Share password bypass (HIGH): enforce password check in get_shared_link_by_token, verify_shared_link_password now returns ShareDto only on correct password. 2. WebDAV MOVE ownership (MEDIUM): add assert_owner on destination parent folder for file moves in both PathResolver and legacy branches. 3. Path traversal defense-in-depth (LOW): add reject_path_traversal() to WebDAV, CalDAV, and CardDAV handlers rejecting '..' segments at HTTP boundary. 4. Setup race condition (LOW): atomic INSERT ... ON CONFLICT DO NOTHING in try_claim_initialization prevents duplicate admin creation.
125 lines
3.8 KiB
Rust
125 lines
3.8 KiB
Rust
use sqlx::PgPool;
|
|
use std::collections::HashMap;
|
|
use std::sync::Arc;
|
|
|
|
use crate::common::errors::{DomainError, ErrorKind};
|
|
use crate::domain::repositories::settings_repository::SettingsRepository;
|
|
|
|
pub struct SettingsPgRepository {
|
|
pool: Arc<PgPool>,
|
|
}
|
|
|
|
impl SettingsPgRepository {
|
|
pub fn new(pool: Arc<PgPool>) -> Self {
|
|
Self { pool }
|
|
}
|
|
}
|
|
|
|
impl SettingsRepository for SettingsPgRepository {
|
|
async fn get(&self, key: &str) -> Result<Option<String>, DomainError> {
|
|
let row =
|
|
sqlx::query_scalar::<_, String>("SELECT value FROM auth.admin_settings WHERE key = $1")
|
|
.bind(key)
|
|
.fetch_optional(self.pool.as_ref())
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::new(
|
|
ErrorKind::InternalError,
|
|
"Settings",
|
|
format!("DB error: {}", e),
|
|
)
|
|
})?;
|
|
|
|
Ok(row)
|
|
}
|
|
|
|
async fn get_by_category(
|
|
&self,
|
|
category: &str,
|
|
) -> Result<HashMap<String, String>, DomainError> {
|
|
let rows = sqlx::query_as::<_, (String, String)>(
|
|
"SELECT key, value FROM auth.admin_settings WHERE category = $1",
|
|
)
|
|
.bind(category)
|
|
.fetch_all(self.pool.as_ref())
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::new(
|
|
ErrorKind::InternalError,
|
|
"Settings",
|
|
format!("DB error: {}", e),
|
|
)
|
|
})?;
|
|
|
|
Ok(rows.into_iter().collect())
|
|
}
|
|
|
|
async fn set(
|
|
&self,
|
|
key: &str,
|
|
value: &str,
|
|
category: &str,
|
|
is_secret: bool,
|
|
updated_by: Option<&str>,
|
|
) -> Result<(), DomainError> {
|
|
sqlx::query(
|
|
"INSERT INTO auth.admin_settings (key, value, category, is_secret, updated_by, updated_at)
|
|
VALUES ($1, $2, $3, $4, $5, NOW())
|
|
ON CONFLICT (key) DO UPDATE
|
|
SET value = $2, category = $3, is_secret = $4, updated_by = $5, updated_at = NOW()"
|
|
)
|
|
.bind(key)
|
|
.bind(value)
|
|
.bind(category)
|
|
.bind(is_secret)
|
|
.bind(updated_by)
|
|
.execute(self.pool.as_ref())
|
|
.await
|
|
.map_err(|e| DomainError::new(
|
|
ErrorKind::InternalError, "Settings", format!("DB error: {}", e),
|
|
))?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
async fn delete(&self, key: &str) -> Result<(), DomainError> {
|
|
sqlx::query("DELETE FROM auth.admin_settings WHERE key = $1")
|
|
.bind(key)
|
|
.execute(self.pool.as_ref())
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::new(
|
|
ErrorKind::InternalError,
|
|
"Settings",
|
|
format!("DB error: {}", e),
|
|
)
|
|
})?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
/// Atomically claim system initialization using INSERT … ON CONFLICT DO NOTHING.
|
|
///
|
|
/// Only the first caller that inserts the row gets `rows_affected == 1`;
|
|
/// concurrent callers see 0 rows affected and receive `false`.
|
|
async fn try_claim_initialization(
|
|
&self,
|
|
admin_user_id: &str,
|
|
) -> Result<bool, DomainError> {
|
|
let result = sqlx::query(
|
|
"INSERT INTO auth.admin_settings (key, value, category, is_secret, updated_by, updated_at)
|
|
VALUES ('system_initialized', 'true', 'system', false, $1, NOW())
|
|
ON CONFLICT (key) DO NOTHING"
|
|
)
|
|
.bind(admin_user_id)
|
|
.execute(self.pool.as_ref())
|
|
.await
|
|
.map_err(|e| DomainError::new(
|
|
ErrorKind::InternalError, "Settings", format!("DB error: {}", e),
|
|
))?;
|
|
|
|
// rows_affected == 1 means we inserted; 0 means another caller already did
|
|
Ok(result.rows_affected() == 1)
|
|
}
|
|
}
|