Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
90 lines
3.9 KiB
TypeScript
90 lines
3.9 KiB
TypeScript
import { test, expect } from './coverage-helpers';
|
|
import { apiLogin, apiCreateFolder } from '../scenarios/helpers';
|
|
|
|
/**
|
|
* ShareDialog coverage — opened from the files context menu. Exercises the
|
|
* link tab (create a public link) and the people tab search, which pulls in
|
|
* the share / shares / grants / recipients endpoint modules.
|
|
*/
|
|
test.beforeEach(async ({ page }) => {
|
|
await apiLogin(page);
|
|
});
|
|
|
|
function uniq(p: string): string {
|
|
return `${p}-${Date.now()}-${Math.floor(Math.random() * 1e6)}`;
|
|
}
|
|
|
|
/**
|
|
* Create the named folder inside a *fresh* parent and open it, so the folder is
|
|
* the only row (the shared `/files` root accumulates hundreds of folders across
|
|
* the suite and its virtualised list won't render an arbitrary one), then open
|
|
* its share dialog from the context menu.
|
|
*/
|
|
async function openShareDialog(page: import('@playwright/test').Page, name: string): Promise<void> {
|
|
const parent = await apiCreateFolder(page, uniq('ShareHost'));
|
|
await apiCreateFolder(page, name, parent.id);
|
|
await page.goto(`/files/${parent.id}`);
|
|
await expect(page.getByTestId(name)).toBeVisible({ timeout: 15_000 });
|
|
await page.getByTestId(name).click({ button: 'right' });
|
|
await page.getByTestId('files-ctx-share-item').click();
|
|
await expect(page.getByTestId('share-dialog')).toBeVisible();
|
|
}
|
|
|
|
test('create a public link via the share dialog', async ({ page }) => {
|
|
const name = uniq('Share');
|
|
await openShareDialog(page, name);
|
|
|
|
// Link tab → fill name/password/expiry, then create a link.
|
|
await page.getByTestId('share-dialog-link-tab').click();
|
|
await page.getByTestId('share-dialog-link-name-input').fill('e2e link');
|
|
await page.getByTestId('share-dialog-link-password-input').fill('secret123', { timeout: 2_000 }).catch(() => {});
|
|
await page.getByTestId('share-dialog-link-expires-input').fill('2031-01-01', { timeout: 2_000 }).catch(() => {});
|
|
await page.getByTestId('share-dialog-create-btn').click();
|
|
|
|
// A created link exposes copy/delete buttons keyed by its id.
|
|
const del = page.locator('[data-testid^="share-dialog-link-delete-btn-"]').first();
|
|
await expect(del).toBeVisible({ timeout: 15_000 });
|
|
await page.locator('[data-testid^="share-dialog-link-copy-btn-"]').first().click({ timeout: 2_000 }).catch(() => {});
|
|
|
|
// Delete the link we just made.
|
|
await del.click();
|
|
const confirm = page.getByTestId('dialog-host-confirm-btn');
|
|
if (await confirm.isVisible().catch(() => false)) await confirm.click();
|
|
|
|
await page.getByTestId('share-dialog-close-btn').click();
|
|
await expect(page.getByTestId('share-dialog')).toHaveCount(0);
|
|
});
|
|
|
|
test('people tab search runs in the share dialog', async ({ page }) => {
|
|
const name = uniq('ShareP');
|
|
await openShareDialog(page, name);
|
|
|
|
await page.getByTestId('share-dialog-people-tab').click();
|
|
await page.getByTestId('share-dialog-search-input').fill('admin');
|
|
// Let the debounced search fire (covers the recipients endpoint).
|
|
await page.waitForTimeout(800);
|
|
|
|
await page.getByTestId('share-dialog-close-btn').click();
|
|
await expect(page.getByTestId('share-dialog')).toHaveCount(0);
|
|
});
|
|
|
|
test('invite an external user by email from the share dialog', async ({ page }) => {
|
|
const name = uniq('ShareE');
|
|
await openShareDialog(page, name);
|
|
await page.getByTestId('share-dialog-people-tab').click();
|
|
|
|
// Typing an email surfaces a synthetic "invite by email" result.
|
|
const email = `invitee-${Date.now()}@example.test`;
|
|
await page.getByTestId('share-dialog-search-input').fill(email);
|
|
const inviteRow = page.locator('[data-testid^="share-dialog-result-email-"]').first();
|
|
await expect(inviteRow).toBeVisible({ timeout: 15_000 });
|
|
await inviteRow.click();
|
|
|
|
// The invitee becomes a pending member.
|
|
await expect(page.locator('[data-testid^="share-dialog-member-"]').first()).toBeVisible({
|
|
timeout: 15_000,
|
|
});
|
|
await page.getByTestId('share-dialog-close-btn').click();
|
|
await expect(page.getByTestId('share-dialog')).toHaveCount(0);
|
|
});
|