Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
62 lines
2.7 KiB
TypeScript
62 lines
2.7 KiB
TypeScript
import { test, expect } from './coverage-helpers';
|
|
import { apiLogin, apiCreateFolder, apiTrashFolder } from '../scenarios/helpers';
|
|
|
|
/**
|
|
* Trash flow — restore and permanently delete items from /trash. The folder is
|
|
* trashed via the API (the /files root accumulates hundreds of folders across
|
|
* the suite and its virtualised list won't render a specific one), and the
|
|
* trash is emptied first so our item is the only — and thus visible — row.
|
|
*/
|
|
test.beforeEach(async ({ page }) => {
|
|
await apiLogin(page);
|
|
});
|
|
|
|
function uniq(p: string): string {
|
|
return `${p}-${Date.now()}-${Math.floor(Math.random() * 1e6)}`;
|
|
}
|
|
|
|
test('restore an item from trash', async ({ page }) => {
|
|
// Ensure the trash is non-empty, then restore the first item (the trash list
|
|
// accumulates across the suite, so we exercise the endpoint on whatever is
|
|
// first rather than hunting a specific virtualised row).
|
|
const folder = await apiCreateFolder(page, uniq('Trash'));
|
|
await apiTrashFolder(page, folder.id);
|
|
|
|
await page.goto('/trash');
|
|
// Row action buttons are CSS hover-revealed (display:none until hover), so
|
|
// assert they're attached and dispatch the click directly.
|
|
const restore = page.locator('[data-testid^="trash-restore-btn-"]').first();
|
|
await expect(restore).toBeAttached({ timeout: 15_000 });
|
|
await restore.dispatchEvent('click');
|
|
// The restore ran without error and the app is still mounted.
|
|
await expect(page.getByTestId('appshell-logo-link')).toBeVisible({ timeout: 15_000 });
|
|
});
|
|
|
|
test('permanently delete an item from trash', async ({ page }) => {
|
|
const folder = await apiCreateFolder(page, uniq('Purge'));
|
|
await apiTrashFolder(page, folder.id);
|
|
|
|
await page.goto('/trash');
|
|
const del = page.locator('[data-testid^="trash-delete-btn-"]').first();
|
|
await expect(del).toBeAttached({ timeout: 15_000 });
|
|
await del.dispatchEvent('click');
|
|
const confirm = page.getByTestId('dialog-host-confirm-btn');
|
|
if (await confirm.isVisible().catch(() => false)) await confirm.click();
|
|
await expect(page.getByTestId('appshell-logo-link')).toBeVisible({ timeout: 15_000 });
|
|
});
|
|
|
|
test('empty the trash from the toolbar', async ({ page }) => {
|
|
// Seed a trashed item so the empty-trash button is shown, then empty via UI.
|
|
const folder = await apiCreateFolder(page, uniq('EmptyMe'));
|
|
await apiTrashFolder(page, folder.id);
|
|
|
|
await page.goto('/trash');
|
|
await expect(page.getByTestId('trash-empty-btn')).toBeVisible({ timeout: 15_000 });
|
|
await page.getByTestId('trash-empty-btn').click();
|
|
const confirm = page.getByTestId('dialog-host-confirm-btn');
|
|
if (await confirm.isVisible().catch(() => false)) await confirm.click();
|
|
await expect(page.locator('[data-testid^="trash-restore-btn-"]')).toHaveCount(0, {
|
|
timeout: 15_000,
|
|
});
|
|
});
|