Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
66 lines
2.6 KiB
TypeScript
66 lines
2.6 KiB
TypeScript
import { test, expect } from './coverage-helpers';
|
|
import { apiLogin, apiCreateFolder } from '../scenarios/helpers';
|
|
|
|
/**
|
|
* Shared route — create a public link via the share dialog, then view it in
|
|
* /shared and open a grant's kebab menu. Exercises the shared page (lanes,
|
|
* rows, menu) plus the grants/shares endpoints.
|
|
*/
|
|
test.beforeEach(async ({ page }) => {
|
|
await apiLogin(page);
|
|
});
|
|
|
|
function uniq(p: string): string {
|
|
return `${p}-${Date.now()}-${Math.floor(Math.random() * 1e6)}`;
|
|
}
|
|
|
|
test('a created link appears in /shared with an openable menu', async ({ page }) => {
|
|
const name = uniq('Shared');
|
|
// Isolate in a fresh parent (the /files root accumulates 100s of folders
|
|
// across the suite and its virtualised list won't render an arbitrary one).
|
|
const parent = await apiCreateFolder(page, uniq('SharedHost'));
|
|
await apiCreateFolder(page, name, parent.id);
|
|
|
|
// Create a public link through the share dialog.
|
|
await page.goto(`/files/${parent.id}`);
|
|
await expect(page.getByTestId(name)).toBeVisible({ timeout: 15_000 });
|
|
await page.getByTestId(name).click({ button: 'right' });
|
|
await page.getByTestId('files-ctx-share-item').click();
|
|
await expect(page.getByTestId('share-dialog')).toBeVisible();
|
|
await page.getByTestId('share-dialog-link-tab').click();
|
|
await page.getByTestId('share-dialog-create-btn').click();
|
|
await expect(page.locator('[data-testid^="share-dialog-link-delete-btn-"]').first()).toBeVisible({
|
|
timeout: 15_000,
|
|
});
|
|
await page.getByTestId('share-dialog-close-btn').click();
|
|
|
|
// It now shows up under My shares; open the first grant's kebab menu.
|
|
await page.goto('/shared');
|
|
// Load more grants if the pager is shown (covers cursor pagination).
|
|
await page.getByTestId('shared-load-more-btn').click({ timeout: 2_000 }).catch(() => {});
|
|
|
|
const kebab = page.locator('[data-testid^="shared-kebab-"]').first();
|
|
await expect(kebab).toBeVisible({ timeout: 15_000 });
|
|
await kebab.click();
|
|
await expect(page.locator('[data-testid^="shared-menu-"]').first()).toBeVisible();
|
|
|
|
// Exercise the link-grant menu actions, then delete the link.
|
|
await page
|
|
.locator('[data-testid^="shared-link-expiry-"]')
|
|
.first()
|
|
.fill('2031-01-01', { timeout: 3_000 })
|
|
.catch(() => {});
|
|
await page
|
|
.locator('[data-testid^="shared-menu-copy-link-"]')
|
|
.first()
|
|
.click({ timeout: 3_000 })
|
|
.catch(() => {});
|
|
await page
|
|
.locator('[data-testid^="shared-delete-link-"]')
|
|
.first()
|
|
.click({ timeout: 3_000 })
|
|
.catch(() => {});
|
|
const confirm = page.getByTestId('dialog-host-confirm-btn');
|
|
if (await confirm.isVisible().catch(() => false)) await confirm.click();
|
|
});
|