Claude
f58d72a780
Benchmark-gated (BEFORE/AFTER + equivalence/safety gate per change), same discipline as rounds 2-12. Full write-up in benches/ROUND13.md. Shipped: - V1 Grouped views windowed (files route + ResourceList). The grid arm was the last unwindowed path (trash is grouped-by-default in grid): each swimlane now feeds its own VirtualList, outer container a flex stack. vitest gate: 800-item grouped grid mounts <120 .file-item (was 800). - Q1 get_users_by_ids drops the <=512 KiB avatar image + ui_preferences JSONB (notification path never reads them). 30-member fan-out 8.60 -> 0.25 ms (34.3x), ~7.7 MB off the wire. - Q2 Login provisioning is_empty() -> SELECT EXISTS for calendar + address book (every login). 0.193 -> 0.170 ms, widens with owned-row count. - Q3 Recent-access prunes only when the upsert inserted (RETURNING xmax=0) — a re-access can't grow the set. 0.567 -> 0.324 ms (1.75x). - L1 Locale supported-codes precomputed once vs rebuilt per anonymous request. 616 -> 17.3 ns (35.7x), 18 -> 1 allocs. - H1 Duplicate /api TraceLayer removed (global stack already wraps it). 1.86 -> 1.42 us/request, -6 allocs. - H2 client_ip span field: borrow-only ClientIpDisplay vs owned String. 187 -> 173 ns, -1 alloc. Not shipped (discipline): the "media hooks read the blob 3x" lead was a correctness bug, not a perf dup — the raw-path metadata/faces readers resolve only for local+unencrypted+single-chunk blobs and silently produce nothing otherwise. Flagged for maintainers; routing through read_blob_bytes is a correctness fix (perf-neutral-to-negative), not a benchmark-gated perf change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BfidAJD5AHw23jtvBUNamB
411 lines
13 KiB
Rust
411 lines
13 KiB
Rust
use chrono::Utc;
|
|
use sqlx::{PgPool, Row, types::Uuid};
|
|
use std::sync::Arc;
|
|
|
|
use crate::common::errors::DomainError;
|
|
use crate::domain::entities::calendar::Calendar;
|
|
use crate::domain::repositories::calendar_repository::{
|
|
CalendarRepository, CalendarRepositoryResult,
|
|
};
|
|
|
|
pub struct CalendarPgRepository {
|
|
pool: Arc<PgPool>,
|
|
}
|
|
|
|
impl CalendarPgRepository {
|
|
pub fn new(pool: Arc<PgPool>) -> Self {
|
|
Self { pool }
|
|
}
|
|
|
|
/// `EXISTS` short-circuit for the login provisioning hook, which only
|
|
/// needs to know whether the user owns ANY calendar. The old
|
|
/// `list_calendars_by_owner(..).is_empty()` hydrated every owned
|
|
/// `Calendar` row (8 cols incl. description/color TEXT) on EVERY login
|
|
/// just to test emptiness — the ROUND9 §7 `Drive::is_empty` COUNT→EXISTS
|
|
/// pattern (benches/ROUND13.md §Q2).
|
|
pub async fn has_owned_calendar(&self, owner_id: Uuid) -> CalendarRepositoryResult<bool> {
|
|
let exists: bool =
|
|
sqlx::query_scalar("SELECT EXISTS(SELECT 1 FROM caldav.calendars WHERE owner_id = $1)")
|
|
.bind(owner_id)
|
|
.fetch_one(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to probe owned calendars: {}", e))
|
|
})?;
|
|
Ok(exists)
|
|
}
|
|
}
|
|
|
|
impl CalendarRepository for CalendarPgRepository {
|
|
async fn create_calendar(&self, calendar: Calendar) -> CalendarRepositoryResult<Calendar> {
|
|
let row = sqlx::query(
|
|
r#"
|
|
INSERT INTO caldav.calendars (id, name, owner_id, description, color, is_public, created_at, updated_at)
|
|
VALUES ($1, $2, $3, $4, $5, $6, $7, $8)
|
|
RETURNING id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
"#
|
|
)
|
|
.bind(calendar.id())
|
|
.bind(calendar.name())
|
|
.bind(calendar.owner_id())
|
|
.bind(calendar.description())
|
|
.bind(calendar.color())
|
|
.bind(false) // is_public doesn't exist as a field
|
|
.bind(calendar.created_at())
|
|
.bind(calendar.updated_at())
|
|
.fetch_one(&*self.pool)
|
|
.await
|
|
.map_err(|e| DomainError::database_error(format!("Failed to create calendar: {}", e)))?;
|
|
|
|
// Build the Calendar object using its with_id constructor
|
|
let result = Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})?;
|
|
|
|
Ok(result)
|
|
}
|
|
|
|
async fn update_calendar(&self, calendar: Calendar) -> CalendarRepositoryResult<Calendar> {
|
|
let now = Utc::now();
|
|
let row = sqlx::query(
|
|
r#"
|
|
UPDATE caldav.calendars
|
|
SET name = $1, description = $2, color = $3, is_public = $4, updated_at = $5
|
|
WHERE id = $6
|
|
RETURNING id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
"#,
|
|
)
|
|
.bind(calendar.name())
|
|
.bind(calendar.description())
|
|
.bind(calendar.color())
|
|
.bind(false) // is_public doesn't exist as a field
|
|
.bind(now)
|
|
.bind(calendar.id())
|
|
.fetch_one(&*self.pool)
|
|
.await
|
|
.map_err(|e| DomainError::database_error(format!("Failed to update calendar: {}", e)))?;
|
|
|
|
// Build the Calendar object using its with_id constructor
|
|
let result = Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})?;
|
|
|
|
Ok(result)
|
|
}
|
|
|
|
async fn delete_calendar(&self, id: &Uuid) -> CalendarRepositoryResult<()> {
|
|
sqlx::query(
|
|
r#"
|
|
DELETE FROM caldav.calendars
|
|
WHERE id = $1
|
|
"#,
|
|
)
|
|
.bind(id)
|
|
.execute(&*self.pool)
|
|
.await
|
|
.map_err(|e| DomainError::database_error(format!("Failed to delete calendar: {}", e)))?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
async fn find_calendar_by_id(&self, id: &Uuid) -> CalendarRepositoryResult<Calendar> {
|
|
let row = sqlx::query(
|
|
r#"
|
|
SELECT id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
FROM caldav.calendars
|
|
WHERE id = $1
|
|
"#,
|
|
)
|
|
.bind(id)
|
|
.fetch_optional(&*self.pool)
|
|
.await
|
|
.map_err(|e| DomainError::database_error(format!("Failed to get calendar by id: {}", e)))?
|
|
.ok_or_else(|| DomainError::not_found("Calendar", id.to_string()))?;
|
|
|
|
let calendar = Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})?;
|
|
|
|
Ok(calendar)
|
|
}
|
|
|
|
async fn find_calendars_by_ids(&self, ids: &[Uuid]) -> CalendarRepositoryResult<Vec<Calendar>> {
|
|
if ids.is_empty() {
|
|
return Ok(Vec::new());
|
|
}
|
|
let rows = sqlx::query(
|
|
r#"
|
|
SELECT id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
FROM caldav.calendars
|
|
WHERE id = ANY($1)
|
|
"#,
|
|
)
|
|
.bind(ids)
|
|
.fetch_all(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to get calendars by ids: {}", e))
|
|
})?;
|
|
|
|
rows.iter()
|
|
.map(|row| {
|
|
Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})
|
|
})
|
|
.collect()
|
|
}
|
|
|
|
async fn list_calendars_by_owner(
|
|
&self,
|
|
owner_id: Uuid,
|
|
) -> CalendarRepositoryResult<Vec<Calendar>> {
|
|
let rows = sqlx::query(
|
|
r#"
|
|
SELECT id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
FROM caldav.calendars
|
|
WHERE owner_id = $1
|
|
ORDER BY name
|
|
"#,
|
|
)
|
|
.bind(owner_id)
|
|
.fetch_all(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to get calendars by owner: {}", e))
|
|
})?;
|
|
|
|
let mut calendars = Vec::new();
|
|
for row in rows {
|
|
let calendar = Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})?;
|
|
calendars.push(calendar);
|
|
}
|
|
|
|
Ok(calendars)
|
|
}
|
|
|
|
async fn find_calendar_by_name_and_owner(
|
|
&self,
|
|
name: &str,
|
|
owner_id: Uuid,
|
|
) -> CalendarRepositoryResult<Calendar> {
|
|
let row = sqlx::query(
|
|
r#"
|
|
SELECT id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
FROM caldav.calendars
|
|
WHERE name = $1 AND owner_id = $2
|
|
"#,
|
|
)
|
|
.bind(name)
|
|
.bind(owner_id)
|
|
.fetch_optional(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to find calendar by name and owner: {}", e))
|
|
})?
|
|
.ok_or_else(|| {
|
|
DomainError::not_found("Calendar", format!("{} (owned by {})", name, owner_id))
|
|
})?;
|
|
|
|
let calendar = Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})?;
|
|
|
|
Ok(calendar)
|
|
}
|
|
|
|
async fn list_public_calendars(
|
|
&self,
|
|
limit: i64,
|
|
offset: i64,
|
|
) -> CalendarRepositoryResult<Vec<Calendar>> {
|
|
let rows = sqlx::query(
|
|
r#"
|
|
SELECT id, name, owner_id, description, color, is_public, created_at, updated_at
|
|
FROM caldav.calendars
|
|
WHERE is_public = true
|
|
ORDER BY name
|
|
LIMIT $1 OFFSET $2
|
|
"#,
|
|
)
|
|
.bind(limit)
|
|
.bind(offset)
|
|
.fetch_all(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to get public calendars: {}", e))
|
|
})?;
|
|
|
|
let mut calendars = Vec::new();
|
|
for row in rows {
|
|
let calendar = Calendar::with_id(
|
|
row.get("id"),
|
|
row.get("name"),
|
|
row.get("owner_id"),
|
|
row.get("description"),
|
|
row.get("color"),
|
|
row.get("created_at"),
|
|
row.get("updated_at"),
|
|
)
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to create calendar object: {}", e))
|
|
})?;
|
|
calendars.push(calendar);
|
|
}
|
|
|
|
Ok(calendars)
|
|
}
|
|
|
|
async fn get_calendar_property(
|
|
&self,
|
|
calendar_id: &Uuid,
|
|
property_name: &str,
|
|
) -> CalendarRepositoryResult<Option<String>> {
|
|
let row = sqlx::query(
|
|
r#"
|
|
SELECT value
|
|
FROM caldav.calendar_properties
|
|
WHERE calendar_id = $1 AND name = $2
|
|
"#,
|
|
)
|
|
.bind(calendar_id)
|
|
.bind(property_name)
|
|
.fetch_optional(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to get calendar property: {}", e))
|
|
})?;
|
|
|
|
Ok(row.map(|r| r.get("value")))
|
|
}
|
|
|
|
async fn set_calendar_property(
|
|
&self,
|
|
calendar_id: &Uuid,
|
|
property_name: &str,
|
|
property_value: &str,
|
|
) -> CalendarRepositoryResult<()> {
|
|
sqlx::query(
|
|
r#"
|
|
INSERT INTO caldav.calendar_properties (calendar_id, name, value)
|
|
VALUES ($1, $2, $3)
|
|
ON CONFLICT (calendar_id, name) DO UPDATE SET value = $3
|
|
"#,
|
|
)
|
|
.bind(calendar_id)
|
|
.bind(property_name)
|
|
.bind(property_value)
|
|
.execute(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to set calendar property: {}", e))
|
|
})?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
async fn remove_calendar_property(
|
|
&self,
|
|
calendar_id: &Uuid,
|
|
property_name: &str,
|
|
) -> CalendarRepositoryResult<()> {
|
|
sqlx::query(
|
|
r#"
|
|
DELETE FROM caldav.calendar_properties
|
|
WHERE calendar_id = $1 AND name = $2
|
|
"#,
|
|
)
|
|
.bind(calendar_id)
|
|
.bind(property_name)
|
|
.execute(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to remove calendar property: {}", e))
|
|
})?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
async fn get_calendar_properties(
|
|
&self,
|
|
calendar_id: &Uuid,
|
|
) -> CalendarRepositoryResult<std::collections::HashMap<String, String>> {
|
|
let rows = sqlx::query(
|
|
r#"
|
|
SELECT name, value
|
|
FROM caldav.calendar_properties
|
|
WHERE calendar_id = $1
|
|
"#,
|
|
)
|
|
.bind(calendar_id)
|
|
.fetch_all(&*self.pool)
|
|
.await
|
|
.map_err(|e| {
|
|
DomainError::database_error(format!("Failed to get calendar properties: {}", e))
|
|
})?;
|
|
|
|
let mut properties = std::collections::HashMap::new();
|
|
for row in rows {
|
|
properties.insert(row.get("name"), row.get("value"));
|
|
}
|
|
|
|
Ok(properties)
|
|
}
|
|
}
|