"""批次 3（D14）回归：配置治理。

- settings.redis_url 成为 Redis 连接串唯一拼装点（celery_app 不再自拼）
- MAX_FILE_SIZE 不再是死配置：上传处理器接 settings（此前硬编码 50MB）
"""
import pytest

from shared.config.settings import Settings


def _fresh_settings(monkeypatch, **env):
    for key, value in env.items():
        monkeypatch.setenv(key, value)
    return Settings()


def test_redis_url_without_password(monkeypatch):
    s = _fresh_settings(
        monkeypatch,
        REDIS_HOST="redis-svc", REDIS_PORT="6380", REDIS_PASSWORD="", REDIS_DB="2",
    )
    assert s.redis_url == "redis://redis-svc:6380/2"


def test_redis_url_with_password(monkeypatch):
    s = _fresh_settings(
        monkeypatch,
        REDIS_HOST="redis-svc", REDIS_PORT="6379", REDIS_PASSWORD="sec ret", REDIS_DB="0",
    )
    assert s.redis_url == "redis://:sec ret@redis-svc:6379/0"


def test_celery_app_reuses_settings_redis_url():
    """celery_app 的 broker/backend 必须等于 settings.redis_url（消除两份拼装实现）。"""
    pytest.importorskip("celery")
    import celery_app
    from shared.config.settings import settings

    assert celery_app.app.conf.broker_url == settings.redis_url
    assert celery_app.app.conf.result_backend == settings.redis_url


def test_upload_handler_uses_settings_max_file_size(monkeypatch):
    """MAX_FILE_SIZE 从 .env 一路生效到上传校验（不再是死配置）。"""
    pytest.importorskip("minio")  # upload_router 导入链含 rustfs_storage
    from shared.config import settings as settings_module
    from shared.utils.file_handler import FileHandler

    monkeypatch.setattr(settings_module.settings, "MAX_FILE_SIZE", 10)
    handler = FileHandler(
        upload_dir=settings_module.settings.UPLOAD_DIR,
        max_file_size=settings_module.settings.MAX_FILE_SIZE,
    )
    assert handler.max_file_size == 10

    import asyncio

    class _FakeUpload:
        filename = "big.step"

        @staticmethod
        async def read():
            return b"x" * 11

    with pytest.raises(ValueError):
        asyncio.run(handler.save_uploaded_file(_FakeUpload()))


def test_router_handlers_wired_to_settings():
    """路由模块的 file_handler 实例必须接 settings（而非构造默认值）。"""
    pytest.importorskip("minio")
    from shared.config.settings import settings
    from moldinsight.api import upload_router, batch_router

    assert upload_router.file_handler.max_file_size == settings.MAX_FILE_SIZE
    assert batch_router.file_handler.max_file_size == settings.MAX_FILE_SIZE